Disable balenaCI auto rebase #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sradevski
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
I am not too keen on having these special cases for certain components if there isn't a very good reason to do so. I understand the sentiment in this case, but let's put some dedicated effort to make the tests run on balenaCI, otherwise this will be a permanent change 😄
nazrhom
approved these changes
Feb 6, 2020
|
@balena-ci retest |
1 similar comment
|
@balena-ci retest |
thgreasi
force-pushed
the
disable-balenaci-autorebase
branch
from
597c76a to
e3b7cb0
Compare
Having autorebase enabled could lead to having more then one instances of the sdk tests running in parallel, which will result all of them failing, b/c they will use the same test user, and will also add unnecessary load to the API. Once we get #582 fixed we can remove this. Change-type: patch See: product-os/scripts#80 Signed-off-by: Thodoris Greasidis <[email protected]>
thgreasi
force-pushed
the
disable-balenaci-autorebase
branch
from
e3b7cb0 to
a30a648
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having autorebase enabled could lead to having
more then one instances of the sdk tests running in
parallel, which will result all of them failing, b/c they
will use the same test user, and will also add
unnecessary load to the API. Once we get #582 fixed
we can remove this.
Change-type: patch
See: product-os/scripts#80
Signed-off-by: Thodoris Greasidis [email protected]
Contributor checklist